fix(#10825): location should be undefined without --location

[ry]

fixes #10825

[lucacasonato]

This seems unfortunate... typeof location !== "undefined" would result in a warning logged to the console.

[ry]

I can remove it - I wanted to address @crowlKats's concern.

[bartlomieju]

I agree with Luca... OTOH it will be hard to discover location API unless you plough through manual. I guess in this situation not showing warning is preferable

[ry]

I would suggest that we leave the warning for the time being. Extra warning is better than confusion. If people feel strongly we can remove it later.

[nayeemrmn]

What do we do about the type declaration?

[bartlomieju]

What do we do about the type declaration?

Ah, that's a good point. We don't have a way to add declarations conditionally (unless it's for the --unstable flag).

[ry]

I think we'll just have to leave the type declaration incorrect when --location is not provided. The situation is not ideal. I don't want to make deno types conditional on --location too.

[kitsonk]

We should amend the JSDoc to make it clear that --location is required to be set to make this available and potentially give an example. That way, people working on intelligent editors can discover it without having to run into the console message.

[kt3k]

How about aligning the behavior with private mode / incognite mode of browsers? Provides localStorage object, but doesn't actually persist data. This doesn't break type declaration, and doesn't break feature detection code (though the result of feature detection might be wrong)

[caspervonb]

Provides localStorage object, but doesn't actually persist data.

Is it no-ops, or is the localStorage effectively an instance of the session storage implementation?

[caspervonb]

Is it no-ops, or is the localStorage effectively an instance of the session storage implementation?

To answer my own question, both.
Safari has a null storage implementation, chrome seems to use a temporary storage location.

[CLAassistant]

All committers have signed the CLA.

[bartlomieju]

This is stale. Closing without a merge.