fix(lsp): do not rename in strings and comments #11041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 18, 2021
cli/lsp/language_server.rs
Outdated
| true, | ||
| true, | ||
| false, | ||
| false, | ||
| false, | ||
| )); |
There was a problem hiding this comment.
By looking at this code alone, it's hard to tell what this means. It would be nice if we didn't use tuples here.
These are the arguments for find_in_strings and find_in_comments.
There was a problem hiding this comment.
I'd be fine using q struct with the more complicated APIs. It gets unwieldy for all of them though.
kitsonk
approved these changes
Jun 18, 2021
cli/lsp/language_server.rs
Outdated
| true, | ||
| true, | ||
| false, | ||
| false, | ||
| false, | ||
| )); |
There was a problem hiding this comment.
I'd be fine using q struct with the more complicated APIs. It gets unwieldy for all of them though.
|
Actually, so you think it warrents a test of some sort? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes denoland/vscode_deno#450
This functionality is not the default with TypeScript so I believe this is a bug and we shouldn't do it.