Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): do not rename in strings and comments #11041

Merged
merged 3 commits into from
Jun 19, 2021
Merged

fix(lsp): do not rename in strings and comments #11041

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c2f30b
fix(lsp): do not rename in strings and comments
dsherret Jun 18, 2021
8940d22
Convert to struct.
dsherret Jun 18, 2021
87a3cd6
Add test.
dsherret Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/lsp/language_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,8 +1769,8 @@ impl Inner {
let req = tsc::RequestMethod::FindRenameLocations((
specifier,
line_index.offset_tsc(params.text_document_position.position)?,
true,
true,
false,
false,
false,
));
Copy link
Member Author

@dsherret dsherret Jun 18, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By looking at this code alone, it's hard to tell what this means. It would be nice if we didn't use tuples here.

These are the arguments for find_in_strings and find_in_comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine using q struct with the more complicated APIs. It gets unwieldy for all of them though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8940d22.


Expand Down