perf(ext/url): optimize UrlParts op serialization #11765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshalling it across the op-layer by joining the substrings into a single "fat" newline-joined string, then splitting JS side.
This shaves off a little over a 1/3 of the overhead per call:
main
(after merging #11763)this PR:
So with this PR and #11763 that's a combined improvement of over 2x ! (~5000ns/call => ~2400ns/call)
Whilst this might appear counterintuitive and "hacky", it works because:
\n
is a safe separator because it's not allowed in URLs, technically could have used any control char but\n
works and is familiar