Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/net): should not panic when listening to unix abstract address #12300

Merged
merged 2 commits into from
Oct 2, 2021
Merged

fix(ext/net): should not panic when listening to unix abstract address #12300

merged 2 commits into from
Oct 2, 2021

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Oct 2, 2021 •
edited
Loading

Fixes #11412

The test detects the runtime whether running into a panic by asset after Deno.listen, would like to see a better way to detect the panic, feel free to suggest.

@ahabhgk ahabhgk marked this pull request as ready for review October 2, 2021 15:30
bartlomieju
bartlomieju approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit 198f5b9 into denoland:main Oct 2, 2021
@ahabhgk ahabhgk deleted the fix_abstract_path_panic branch October 3, 2021 05:13
ry pushed a commit that referenced this pull request Oct 4, 2021
@ahabhgk @ry
fix(ext/net): should not panic when listening to unix abstract address (
c9b0aaa 
#12300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when listening to unix socket abstract address
2 participants
@ahabhgk @bartlomieju