-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce navigator.language #12322
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
72dcc05
Add navigator.language and tests
AnInternetTroll c114fde
Merge github.com:AnInternetTroll/deno
AnInternetTroll 3955a42
Add typings and a fancier function thx @crowlKats
AnInternetTroll 4576676
Add `configurable` and `enumerable` properties and add `language` to …
AnInternetTroll 9e35957
Re-format code
AnInternetTroll fcdbd92
Remove --allow-env requirement for `navigator.language`
AnInternetTroll cde6093
Merge branch 'main' of github.com:denoland/deno
AnInternetTroll e1acc7f
Move from making an op call to having a Bootstrap option
AnInternetTroll 792e42d
Merge branch 'main' of github.com:denoland/deno
AnInternetTroll c63e28b
Add test for `navigator.languages` and freeze it
AnInternetTroll 3408957
Remove debug print
AnInternetTroll 833e51d
Set `LANGUAGE` env variable in tests
AnInternetTroll 05a8829
Fix test to use LC_ALL instead of LANG
AnInternetTroll 0154976
Merge github.com:denoland/deno
AnInternetTroll 09b596e
Merge github.com:denoland/deno
AnInternetTroll f21e908
Replace `Navigator` with `WorkerNavigatorPrototype` where appropriate
AnInternetTroll e244948
Merge branch 'main' into AnInternetTroll/main
bartlomieju f33c85a
update to latest rusty_v8
bartlomieju 81f4707
cleanup
bartlomieju 683020c
Merge branch 'main' into AnInternetTroll/main
bartlomieju 7eb1523
try to fix test
bartlomieju 10d548e
Use LC_ALL in test instead of LANG and LANGUAGE
AnInternetTroll 6d990ae
Format
AnInternetTroll bd8ee25
Merge branch 'main' into AnInternetTroll/main
bartlomieju c98844a
fix lint
bartlomieju 9cec295
Merge branch 'main' into main
bartlomieju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log(navigator.language); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log(navigator.languages); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like an error - there's no region
EN
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Silly mistake on my part, I'll fix it