Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply DenoError TooLarge #1298

Merged
merged 3 commits into from Dec 9, 2018
Merged

Apply DenoError TooLarge #1298

merged 3 commits into from Dec 9, 2018

Conversation

binaryta
Copy link
Contributor

@binaryta binaryta commented Dec 9, 2018 •
edited

I've modified error type in js/buffer.ts to DenoError from Error, so added enum type to msg.fbs.

Test

  • ./tools/test.py
  • ./tools/test.py
  • ./tools/format.py

ry
ry approved these changes Dec 9, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice! Thanks!

@ry ry merged commit c427c2d into denoland:master Dec 9, 2018
ry added a commit to ry/deno that referenced this pull request Dec 14, 2018
@ry
v0.2.3
f815090 
- console.assert should not throw error (denoland#1335)
- Support more modes in deno.open (denoland#1282, denoland#1336)
- Simplify code fetch logic (denoland#1322)
- readDir entry mode (denoland#1326)
- Use stderr for exceptions (denoland#1303)
- console.log formatting improvements (denoland#1327, denoland#1299)
- Expose TooLarge error code for buffers (denoland#1298)
@ry ry mentioned this pull request Dec 14, 2018
Merged
ry added a commit that referenced this pull request Dec 14, 2018
@ry
v0.2.3
c69d2f5 
- console.assert should not throw error (#1335)
- Support more modes in deno.open (#1282, #1336)
- Simplify code fetch logic (#1322)
- readDir entry mode (#1326)
- Use stderr for exceptions (#1303)
- console.log formatting improvements (#1327, #1299)
- Expose TooLarge error code for buffers (#1298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@binaryta @ry