Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/fetch): Response.json() #13537

Closed
wants to merge 2 commits into from
Closed

feat(ext/fetch): Response.json() #13537

wants to merge 2 commits into from

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Jan 30, 2022 •
edited by lucacasonato
Loading

A simple/tentative implementation of whatwg/fetch#1389

Closes #13902

@AaronO
feat(ext/fetch): Response.json()
72d46ac 
A simple/tentative implementation of whatwg/fetch#1389
lucacasonato
lucacasonato requested changes Jan 30, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending WPT and spec changes. Do not merge.

@AaronO
handle content-type override
2142d7b 
and factor out ResponseInit based constructors out to a fromInit() helper
@lucacasonato
Copy link
Member

Thanks @AaronO, but closing in favor of #14566. I implemented the change as per the latest spec revision there, and enabled the WPTs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreubotella andreubotella andreubotella left review comments

@lucacasonato lucacasonato lucacasonato requested changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@crowlKats crowlKats Awaiting requested review from crowlKats

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Response.json()
3 participants
@AaronO @lucacasonato @andreubotella