Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/web): implement static Response.json #14566

Merged
merged 2 commits into from
May 13, 2022

Conversation

lucacasonato
Copy link
Member

This commit adds support for the static Response.json method.

Spec change: whatwg/fetch#1392
Tests: web-platform-tests/wpt#32825

Closes #13902

@lucacasonato lucacasonato force-pushed the static_response_json branch 2 times, most recently from 6c69e17 to 04622bc Compare May 13, 2022 11:42
This commit adds support for the static `Response.json` method.
@lucacasonato lucacasonato marked this pull request as ready for review May 13, 2022 11:46
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

Minor suggestion to link to spec for context

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lucacasonato lucacasonato merged commit a5b50d0 into denoland:main May 13, 2022
@lucacasonato lucacasonato deleted the static_response_json branch May 13, 2022 12:28
sigmaSd pushed a commit to sigmaSd/deno that referenced this pull request May 29, 2022
This commit adds support for the static `Response.json` method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Response.json()
3 participants