New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add "deno check" subcommand for type checking #14072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please implement the env var described here #11786 |
cli/flags.rs
Outdated
Arg::new("all") | ||
.long("all") | ||
.help("Type-check all modules, including remote") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to --remote
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to
--remote
?
That might be better. If we made another category of diagnostics/locations opt-in, that should be its own flag e.g. deno check --remote --dts
.
At this point I'm not sure if deno run --check
is a good idea or if we should insist deno check
is used to type check. If we kept it the API would have to be more like deno run --check=--remote,--dts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I'm not sure if deno run --check is a good idea
We need it for at least a few minor releases to give users time to migrate to deno check
. I don't feel strongly about it, but I think we could punt this discussion until later time.
@ry this is now ready to land, merge on approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently just an alias for "deno cache".
Prints warning for "deno run" subcommand if "--check" flag is not present
and there's no "--no-check" flag. Adds "DENO_FUTURE_CHECK" env
variable that allows to opt into new behavior now.
Closes #14071
Closes #11786