Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "deno check" subcommand for type checking #14072

Merged
merged 29 commits into from
Apr 10, 2022
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c6ed04d
refactor(flags): rename CheckFlag to TypecheckMode
bartlomieju Mar 25, 2022
1351866
add check subcommand
bartlomieju Mar 22, 2022
7a9ce27
add warning
bartlomieju Mar 22, 2022
451fe69
add DENO_FUTURE_CHECK
bartlomieju Mar 24, 2022
6b63470
fix flags tests
bartlomieju Mar 25, 2022
5a6de0e
update some tests
bartlomieju Mar 25, 2022
e09b979
update for TypecheckMode
bartlomieju Mar 26, 2022
63f8484
Merge branch 'main' into deno_check
bartlomieju Mar 26, 2022
16eb1a5
update more tests
bartlomieju Mar 26, 2022
357abc7
update more tests
bartlomieju Mar 26, 2022
35d3bee
update more tests2
bartlomieju Mar 26, 2022
e074380
update more tests3
bartlomieju Mar 26, 2022
c6def07
update more tests4
bartlomieju Mar 26, 2022
067f1a9
add tests for deno run --check
bartlomieju Mar 27, 2022
8dc537c
add check tests
bartlomieju Mar 27, 2022
1ccc295
add check tests
bartlomieju Mar 27, 2022
df85725
fix flag tests
bartlomieju Mar 27, 2022
068bb64
Merge branch 'main' into deno_check
bartlomieju Mar 29, 2022
7a0c104
Merge branch 'main' into deno_check
bartlomieju Mar 29, 2022
0997fbd
review
bartlomieju Mar 29, 2022
e712f6a
backticks
bartlomieju Mar 30, 2022
992fc2f
add --all flag to deno check
bartlomieju Mar 30, 2022
0467edc
fix flags tests
bartlomieju Mar 30, 2022
779d1f5
add tests for --all
bartlomieju Mar 30, 2022
e2cf4dd
Merge branch 'main' into deno_check
bartlomieju Apr 8, 2022
30fc1ee
rename --all to --remote
bartlomieju Apr 8, 2022
c8a6ffa
Merge branch 'main' into deno_check
bartlomieju Apr 10, 2022
1ab7cdf
fix after merge
bartlomieju Apr 10, 2022
a3eff0f
reset CI
bartlomieju Apr 10, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cli/emit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ pub fn is_emittable(
pub struct CheckOptions {
/// The check flag from the option which can effect the filtering of
/// diagnostics in the emit result.
pub typecheck_mode: flags::TypecheckMode,
pub type_check_mode: flags::TypeCheckMode,
/// Set the debug flag on the TypeScript type checker.
pub debug: bool,
/// If true, any files emitted will be cached, even if there are diagnostics
Expand Down Expand Up @@ -430,7 +430,7 @@ pub fn check_and_maybe_emit(
root_names,
})?;

let diagnostics = if options.typecheck_mode == flags::TypecheckMode::Local {
let diagnostics = if options.type_check_mode == flags::TypeCheckMode::Local {
response.diagnostics.filter(|d| {
if let Some(file_name) = &d.file_name {
!file_name.starts_with("http")
Expand Down