Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check): --remote and --no-remote should be mutually exclusive #14964

Merged
merged 11 commits into from
Sep 1, 2022
Merged

fix(check): --remote and --no-remote should be mutually exclusive #14964

merged 11 commits into from
Sep 1, 2022

Conversation

GJZwiers
Copy link
Contributor

Updates deno check to throw an error when both --remote and --no-remote are used.

bartlomieju
bartlomieju requested changes Jun 26, 2022
View reviewed changes
cli/tests/integration/check_tests.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @GJZwiers

@bartlomieju bartlomieju merged commit cbd8307 into denoland:main Sep 1, 2022
@GJZwiers GJZwiers deleted the fix_check_mutually_exclusive_args branch September 1, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GJZwiers @bartlomieju