Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/http): reading headers with ongoing body reader #15161

Merged
merged 6 commits into from
Jul 12, 2022
Merged

fix(ext/http): reading headers with ongoing body reader #15161

merged 6 commits into from
Jul 12, 2022

Conversation

littledivy
Copy link
Member

Fixes #15107

@littledivy littledivy marked this pull request as ready for review July 12, 2022 04:42
@cjihrig
Copy link
Contributor

cjihrig commented Jul 12, 2022 •
edited
Loading

Confirmed that this fixes the crash on my machine (even without the revert in #3469).

@cjihrig cjihrig merged commit 5b26a4a into denoland:main Jul 12, 2022
cjihrig pushed a commit that referenced this pull request Jul 12, 2022
@littledivy @cjihrig
fix(ext/http): reading headers with ongoing body reader (#15161)
1b45d6f
@sant123
Copy link

sant123 commented Jul 15, 2022

Thank you so much for the fix 🤗

@predetermined predetermined mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno has panicked - ext/http/lib.rs
3 participants
@littledivy @cjihrig @sant123