Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Free up JsRuntime state global handles before snapshot #15491

Merged
merged 4 commits into from
Aug 21, 2022
Merged

fix: Free up JsRuntime state global handles before snapshot #15491

merged 4 commits into from
Aug 21, 2022

Conversation

bakjos
Copy link
Contributor

@bakjos bakjos commented Aug 18, 2022

fix: #15490

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ry ry changed the title feat(feat): Free up JsRuntime state global handles before snapshot fix: Free up JsRuntime state global handles before snapshot Aug 20, 2022
bartlomieju
bartlomieju approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bakjos, nice fix

@bartlomieju bartlomieju merged commit 5ea5170 into denoland:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot global handle not serialized
3 participants
@bakjos @CLAassistant @bartlomieju