Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): Deno.setRaw -> Deno.stdin.setRaw #15797

Merged
merged 9 commits into from
Sep 28, 2022
Merged

feat(unstable): Deno.setRaw -> Deno.stdin.setRaw #15797

merged 9 commits into from
Sep 28, 2022

Conversation

lucacasonato
Copy link
Member

Towards #15796

@lucacasonato lucacasonato force-pushed the stdin_set_raw branch 2 times, most recently from e8b7d5a to afb8349 Compare September 7, 2022 10:11
littledivy
littledivy reviewed Sep 7, 2022
View reviewed changes
runtime/js/40_files.js Outdated Show resolved Hide resolved
crowlKats
crowlKats reviewed Sep 7, 2022
View reviewed changes
cli/dts/lib.deno.ns.d.ts Outdated Show resolved Hide resolved
dsherret
dsherret previously requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should do this because I think it would also be applicable to ptys in the future? Maybe I'm wrong about this one.

@lucacasonato
Copy link
Member Author

We can add a setRaw method to ptys then.

I don't want to stabilize anything that references rids in any way.

dsherret
dsherret reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a setRaw method to ptys then.

Good point. We could just add some methods on it.

@bartlomieju bartlomieju added this to the 1.26 milestone Sep 26, 2022
bartlomieju
bartlomieju approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsherret
dsherret approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 70bc0eb into denoland:main Sep 28, 2022
@lucacasonato lucacasonato deleted the stdin_set_raw branch September 28, 2022 13:03
@cbrnr cbrnr mentioned this pull request Sep 29, 2022
Open
6 tasks
@Yaikava Yaikava mentioned this pull request Oct 1, 2022
Open
This was referenced Dec 27, 2022
Merged
Closed
@sylc sylc mentioned this pull request Dec 31, 2022
Merged
@rivy rivy mentioned this pull request Mar 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats left review comments

@littledivy littledivy littledivy left review comments

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lucacasonato @dsherret @crowlKats @bartlomieju @littledivy