-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add a report lint config setting #16045
feat(lint): add a report lint config setting #16045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you update cli/schemas/config-file.v1.json
?
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick and it's good to land.
cli/schemas/config-file.v1.json
Outdated
@@ -249,6 +249,10 @@ | |||
"uniqueItems": true | |||
} | |||
} | |||
}, | |||
"report": { | |||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to use enum
here with default
set to pretty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Builds off this PR to add a "report" setting to deno.json which can be "pretty", "compact", or "json"
#15926
Open to feedback. Struggled a bit with the rust code and probably easier ways to do things