Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Fixed bug where the progress bar did not clear #16401

Merged
merged 4 commits into from
Oct 24, 2022
Merged

fix(cli): Fixed bug where the progress bar did not clear #16401

merged 4 commits into from
Oct 24, 2022
+16 −1

Conversation

k-nasa
Copy link
Contributor

@k-nasa k-nasa commented Oct 24, 2022

WHY

fix: #16381

In REPL, importing a wrong url normally throw an error then indefinitely show download loader without possibility to continue.

progress_bar.clear is never called if an error occurs in these codes.

https://github.com/k-nasa/deno/blob/67984e9a314410371b05b2b6f2b701d192e000d3/cli/proc_state.rs#L395-L415

WHAT

It looks like a simple solution to speed up the timing of clearing.

Proof

I confirmed progress bar disappeared.

2022-10-24.23.27.34.mov

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

k-nasa
k-nasa commented Oct 24, 2022
View reviewed changes
cli/proc_state.rs Outdated Show resolved Hide resolved
@k-nasa k-nasa marked this pull request as ready for review October 24, 2022 14:53
bartlomieju
bartlomieju approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix @k-nasa

@bartlomieju bartlomieju merged commit 7a65b8e into denoland:main Oct 24, 2022
@k-nasa k-nasa deleted the k-nasa/clear_indicator_when_wrong_url branch October 25, 2022 00:30
@k-nasa
Copy link
Contributor Author

k-nasa commented Oct 25, 2022

Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno REPL imports stuck for wrong url
4 participants
@k-nasa @CLAassistant @dsherret @bartlomieju