Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno REPL imports stuck for wrong url #16381

Closed
JOTSR opened this issue Oct 21, 2022 · 2 comments · Fixed by #16401
Closed

Deno REPL imports stuck for wrong url #16381

JOTSR opened this issue Oct 21, 2022 · 2 comments · Fixed by #16401
Labels
bug Something isn't working correctly repl related to the Read-Eval-Print-Loop functionality of Deno

Comments

@JOTSR
Copy link
Contributor

JOTSR commented Oct 21, 2022

In REPL, importing a wrong url normally throw an error then indefinitely show download loader without possibility to continue.
image
New loader seem to disapeer only after dowloading and parsing comletion and don't correctly clear on error.
Same for dynamic imports
image
Correctly works after caching the url
image
Tested on deno (windows and linux) 1.26 and earlier
@magurotuna magurotuna added bug Something isn't working correctly repl related to the Read-Eval-Print-Loop functionality of Deno labels Oct 24, 2022
@k-nasa
Copy link
Contributor

k-nasa commented Oct 24, 2022

I want to work on this

@magurotuna
Copy link
Member

Go ahead 🚀

@k-nasa k-nasa mentioned this issue Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly repl related to the Read-Eval-Print-Loop functionality of Deno
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): Fixed bug where the progress bar did not clear k-nasa/deno
3 participants
@magurotuna @k-nasa @JOTSR