Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm/types): resolve main entrypoint declaration file when no types entry #16791

Merged
merged 1 commit into from
Nov 24, 2022
Merged

fix(npm/types): resolve main entrypoint declaration file when no types entry #16791

merged 1 commit into from
Nov 24, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 24, 2022 •
edited
Loading

Makes npm:@scriptserver/core work.

Closes #16782

@dsherret dsherret enabled auto-merge (squash) November 24, 2022 17:54
bartlomieju
bartlomieju approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 823a5f6 into denoland:main Nov 24, 2022
@dsherret dsherret deleted the fix_npm_no_types branch November 24, 2022 18:14
bartlomieju pushed a commit that referenced this pull request Nov 24, 2022
@dsherret @bartlomieju
fix(npm/types): resolve main entrypoint declaration file when no type…
184c9b9 
…s entry (#16791)

Closes #16782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm specifiers types not working for package with no "types" entry and another with an incorrect "types" entry
2 participants
@dsherret @bartlomieju