Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): introduce SafeRegExp to primordials #17592

Merged
merged 12 commits into from Feb 28, 2023

Conversation

petamoriken
Copy link
Contributor

Closes #17485

@petamoriken petamoriken marked this pull request as ready for review January 31, 2023 11:37
@petamoriken
Copy link
Contributor Author

benchmark for console

const count = 100000;
Deno.bench("console", () => {
  for (let i = 0; i < count; i++) console.log("Hello World");
});

before:

cpu: Apple M1
runtime: deno 1.30.0 (aarch64-apple-darwin)

benchmark      time (avg)             (min … max)       p75       p99      p995
------------------------------------------------- -----------------------------
console     64.63 ms/iter   (64.02 ms … 65.64 ms)   64.9 ms  65.64 ms  65.64 ms

after:

cpu: Apple M1
runtime: deno 1.30.0 (aarch64-apple-darwin)

benchmark      time (avg)             (min … max)       p75       p99      p995
------------------------------------------------- -----------------------------
console     64.15 ms/iter   (63.52 ms … 64.92 ms)  64.41 ms  64.92 ms  64.92 ms

@petamoriken
Copy link
Contributor Author

@littledivy please review this

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

primordials: Introduce SafeRegExp
2 participants