Follow redirect location as new referrers for nested module imports #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Apr 1, 2019
cli/deno_dir.rs
Outdated
| /// download will be written to "filename". This happens no matter the value of | ||
| /// use_cache. | ||
| fn get_source_code_async( | ||
| self: &Self, |
There was a problem hiding this comment.
I'd prefer if we could keep these functions out of DenoDir and rather provide explicit parameters for whatever it needs. (During a recent refactoring in this file I discovered these methods to be rather tangled up without a particularly good reason.)
"filename" should already give the location of the cache. You should be able to use that for resolving the "mime file" ?
ry
reviewed
Apr 1, 2019
ry
reviewed
Apr 1, 2019
| // May not exist. DON'T unwrap. | ||
| let _ = std::fs::remove_file(&metadata_filename); | ||
| let p = PathBuf::from(filename); | ||
| // TODO(kevinkassimo): consider introduce serde::Deserialize to make things simpler. |
There was a problem hiding this comment.
Yes, we need to do this soon. There's another place in the source map handler where I'm manually parsing JSON like this.
kevinkassimo
force-pushed
the
import/redirect
branch
from
052049e
to
d5b79d2
Compare
ry
reviewed
Apr 1, 2019
ry
reviewed
Apr 1, 2019
ry
reviewed
Apr 1, 2019
ry
reviewed
Apr 1, 2019
ry
reviewed
Apr 1, 2019
kevinkassimo
force-pushed
the
import/redirect
branch
from
d7fcdcd
to
8dd76fd
Compare
ry
reviewed
Apr 1, 2019
kevinkassimo
changed the title
kevinkassimo
force-pushed
the
import/redirect
branch
from
b105117
to
fb29581
Compare
ry
reviewed
Apr 1, 2019
kevinkassimo
force-pushed
the
import/redirect
branch
from
fb29581
to
6aea655
Compare
|
@kevinkassimo Is this ready or are you still working on it? I'm ready to land. |
ry
reviewed
Apr 2, 2019
|
@ry should be ready |
ry
reviewed
Apr 2, 2019
ry
reviewed
Apr 2, 2019
ry
reviewed
Apr 2, 2019
ry
reviewed
Apr 2, 2019
ry
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to resolve #1742 and #2021. Both examples in the 2 issues seem to be working now:
It is achieved by extending
*.mimefiles into*.headers.jsonfiles, which is now of JSON format and might optionally contain a fieldredirect_tothat points to the location of the final redirect.For example, for
https://import-meta.now.sh/redirect.js,$DENO_DIR/deps/https/import-meta.now.sh/redirect.jsis never created. Instead,$DENO_DIR/deps/https/import-meta.now.sh/redirect.js.headers.jsonis created with the following content:which points to the actual cached file location (
https://import-meta.now.sh/sub/final1.js)TODO:
(Struggling to catch up with recent codebase changes so there is high potential of new bugs introduced)