-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use -O3 instead of -O #2070
Use -O3 instead of -O #2070
Conversation
Attempting to correct hyper_hello latency problem.
Huh, this failed when I tried it locally! Edit: maybe It wasn't clear to me if this actually affected hyper_hello as the size remained the same :/ |
Does this definitely apply to the hyper_hello binary? |
Yes rather sure |
I think this is a good line of reasoning tho... We should compare cargo built hyper_hello vs gn built hyper_hello and see if there's a difference. (Unfortunately at the moment I can't repeat the latency slowness locally - only on travis.) |
Can we push the binary somewhere/inspect what travis is building? I was wondering if the is_official block could be an else block after is_debug (though it doesn't seem to make a difference to the hyper_hello binary either.) |
It didn't deliver the expected performance improvements, so let's go back and use Rust defaults again. This reverts commit 4232c89.
It didn't deliver the expected performance improvements, so let's go back and use Rust defaults again. This reverts commit 4232c89.
Attempting to correct hyper_hello latency problem.