Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -O3 instead of -O #2070

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Use -O3 instead of -O #2070

merged 2 commits into from
Apr 8, 2019

Conversation

ry
Copy link
Member

@ry ry commented Apr 8, 2019

Attempting to correct hyper_hello latency problem.

Attempting to correct hyper_hello latency problem.
@hayd
Copy link
Contributor

hayd commented Apr 8, 2019

Huh, this failed when I tried it locally!

Edit: maybe args += [ "-C", "debuginfo=0", "-C", "opt-level=3" ] ?

It wasn't clear to me if this actually affected hyper_hello as the size remained the same :/

@ry ry merged commit 4232c89 into denoland:master Apr 8, 2019
@hayd
Copy link
Contributor

hayd commented Apr 8, 2019

Does this definitely apply to the hyper_hello binary?

@ry
Copy link
Member Author

ry commented Apr 8, 2019

Yes rather sure

@ry
Copy link
Member Author

ry commented Apr 8, 2019

I think this is a good line of reasoning tho... We should compare cargo built hyper_hello vs gn built hyper_hello and see if there's a difference. (Unfortunately at the moment I can't repeat the latency slowness locally - only on travis.)

@hayd
Copy link
Contributor

hayd commented Apr 8, 2019

Can we push the binary somewhere/inspect what travis is building?
That way we can compare gn built hyper_hello vs cargo/rustc built. If they're the same size we can be pretty sure they're built with the same flags...

I was wondering if the is_official block could be an else block after is_debug (though it doesn't seem to make a difference to the hyper_hello binary either.)

piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 29, 2019
It didn't deliver the expected performance improvements, so let's go
back and use Rust defaults again.

This reverts commit 4232c89.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Aug 29, 2019
It didn't deliver the expected performance improvements, so let's go
back and use Rust defaults again.

This reverts commit 4232c89.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants