New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/fetch): do not truncate field value in EventSource
#22368
Conversation
could you add a test? |
I'll try to fix this in another PR. |
fe914fb
to
0662c23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Let's merge this after the linked robustness PR.
Thank you for the contributions <3
Is there a way to consume this fix from Deno 1.41.3 in order to work around this issue until there is an official release? |
I found this polyfill for Node which works well with just: import EventSource from "npm:eventsource"; |
@bartlomieju, please take a look at #22493 first. Testing this fix requires there being no unhandled rejections or resource leaks. |
This PR fixes all unhandled rejections and resource leaks found while adding a test for #22368.
Head branch was pushed to by a user without write access
8484add
to
324583d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on #22493. Closes #22367.