fix(ext/fetch): make EventSource more robust
#22493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f-0b
force-pushed
the
eventsource-unhandled-rejection
branch
from
83d2292
to
f1f6ad8
Compare
0f-0b
force-pushed
the
eventsource-unhandled-rejection
branch
from
f1f6ad8
to
aee159a
Compare
aapoalas
approved these changes
Mar 5, 2024
ext/fetch/27_eventsource.js
Outdated
| if (this[_readyState] !== CLOSED) { | ||
| this[_readyState] = OPEN; | ||
| this.dispatchEvent(new Event("open")); | ||
| if (this[_readyState] === CLOSED) { |
There was a problem hiding this comment.
praise: Nice inversion of ifs to reduce unnecessary indentation.
ext/fetch/27_eventsource.js
Outdated
| if (this[_lastEventID] !== "") { | ||
| lastEventIDValue = this[_lastEventID]; | ||
| } | ||
| this[_reestablishConnection](); |
There was a problem hiding this comment.
praise: Excellent deduplication work!
0f-0b
force-pushed
the
eventsource-unhandled-rejection
branch
from
aee159a
to
05bc224
Compare
0f-0b
force-pushed
the
eventsource-unhandled-rejection
branch
from
05bc224
to
aa35d09
Compare
|
@aapoalas Any ideas why the CI failed? Seems like a flaky test to me. |
Lint failed from clippy not running or finding something fishy. Either main contained something fishy or it's indeed flaky :/ |
0f-0b
force-pushed
the
eventsource-unhandled-rejection
branch
from
8ee5834
to
41a494f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all unhandled rejections and resource leaks found while adding a test for #22368.