feat(unstable/publish): error when a package's module is excluded from publishing #22948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 15, 2024
| PublishDiagnostic::UnsupportedJsxTsx { .. } => None, | ||
| UnsupportedJsxTsx { .. } => None, | ||
| ExcludedModule { .. } => { | ||
| Some(Cow::Borrowed("https://jsr.io/go/excluded-module")) |
There was a problem hiding this comment.
todo: add a page for this in the jsr registry
There was a problem hiding this comment.
Do you want to address this TODO before landing?
There was a problem hiding this comment.
Yes, if this url looks ok.
There was a problem hiding this comment.
Looks okay, but it's redirecting to the main doc page right now. I guess we'll create that page after landing this PR?
I misunderstood. Yeah looks good.
There was a problem hiding this comment.
I opened jsr-io/jsr#318
bartlomieju
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22657