-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable/publish): error when a package's module is excluded from publishing #22948
Merged
dsherret
merged 4 commits into
denoland:main
from
dsherret:feat_publish_error_excluding_pkg_module
Mar 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
38803ca
feat(unstable/publish): error when a package's module is excluded fro…
dsherret d9d9e3c
Merge branch 'main' into feat_publish_error_excluding_pkg_module
dsherret ec816f2
Update message
dsherret 9704e75
Merge branch 'main' into feat_publish_error_excluding_pkg_module
dsherret File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// test for a module that's excluded from being | ||
// published, but is found in the module graph | ||
{ | ||
"args": "publish --dry-run", | ||
"output": "publish.out", | ||
"exitCode": 1 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "@denotest/excluded-export-module", | ||
"version": "0.1.0", | ||
"exports": "./main.ts", | ||
"publish": { | ||
"exclude": [ | ||
"./excluded_file1.ts", | ||
"./excluded_file2.ts", | ||
"./not_imported_excluded_file.ts" | ||
] | ||
} | ||
} |
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import "./excluded_file1.ts"; | ||
import "./excluded_file2.ts"; |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
Check file:///[WILDLINE]/main.ts | ||
Checking for slow types in the public API... | ||
Check file:///[WILDLINE]/main.ts | ||
error[excluded-module]: module in package's module graph was excluded from publishing | ||
--> [WILDLINE]excluded_file1.ts | ||
= hint: remove the module from 'exclude' and/or 'publish.exclude' in the config file or don't reference it in any code used by your package | ||
|
||
info: excluded modules referenced via a package export will error at runtime due to not existing in the package | ||
docs: https://jsr.io/go/excluded-module | ||
|
||
error[excluded-module]: module in package's module graph was excluded from publishing | ||
--> [WILDLINE]excluded_file2.ts | ||
= hint: remove the module from 'exclude' and/or 'publish.exclude' in the config file or don't reference it in any code used by your package | ||
|
||
info: excluded modules referenced via a package export will error at runtime due to not existing in the package | ||
docs: https://jsr.io/go/excluded-module | ||
|
||
error: Found 2 problems |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: add a page for this in the jsr registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to address this TODO before landing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if this url looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, but it's redirecting to the main doc page right now. I guess we'll create that page after landing this PR?I misunderstood. Yeah looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened jsr-io/jsr#318