feat(task): cross-platform shebang support #23091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Mar 27, 2024
| let executable_command = | ||
| deno_task_shell::ExecutableCommand::new("deno".to_string()); | ||
| let executable_command = deno_task_shell::ExecutableCommand::new( | ||
| "deno".to_string(), |
There was a problem hiding this comment.
Just making sure - specifying deno here will use the current executable, not look up deno on the PATH?
There was a problem hiding this comment.
Yeah, it's for the display name in error messages.
There was a problem hiding this comment.
By the way, this is also a bug fix because previously it wouldn't use the current executable.
Edit: Actually no, it worked correctly before.
|
Opened denoland/docs#384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cross-platform shebang support (supports using shebangs in
deno taskon Windows)denoland/deno_task_shell#113