Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lsp): unify caching into LspCache #23746

Merged
merged 5 commits into from
May 9, 2024
Merged

refactor(lsp): unify caching into LspCache #23746

merged 5 commits into from
May 9, 2024

Conversation

nayeemrmn
Copy link
Collaborator

More extraction from #21029.

@nayeemrmn nayeemrmn added the ci-bench put this on a PR to run the benchmarks label May 8, 2024
dsherret
dsherret reviewed May 8, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! It would be nice to have some unit tests on RedirectResolver somehow though

cli/lsp/tsc.rs Show resolved Hide resolved
cli/lsp/resolver.rs Show resolved Hide resolved
cli/lsp/resolver.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn removed the ci-bench put this on a PR to run the benchmarks label May 9, 2024
@nayeemrmn nayeemrmn requested a review from dsherret May 9, 2024 18:14
dsherret
dsherret approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cli/lsp/resolver.rs
})
),
]
);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@nayeemrmn nayeemrmn merged commit 439b3b8 into denoland:main May 9, 2024
18 checks passed
@nayeemrmn nayeemrmn deleted the lsp-cache branch May 9, 2024 19:22
dsherret pushed a commit that referenced this pull request May 10, 2024
@nayeemrmn @dsherret
refactor(lsp): unify caching into LspCache (#23746)
f7f9383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeemrmn @dsherret