Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support top-level-await in TypeScript #3024

Merged
merged 1 commit into from Sep 30, 2019
Merged

Conversation

ry
Copy link
Member

@ry ry commented Sep 26, 2019

Fixes #471

After this we should clean up the documentation...

@kitsonk
Copy link
Contributor

kitsonk commented Sep 28, 2019

TLA for TypeScript is scheduled for 3.7, planned for Nov 7th.

Refs: microsoft/TypeScript#33352 and microsoft/TypeScript#25988

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am expecting many subtle bugs in our top level await support.
E.g. certain type checks that typescript will get wrong, module initialization in the wrong order / racy, etc.

@ry
Copy link
Member Author

ry commented Sep 30, 2019

I am expecting many subtle bugs in our top level await support. E.g. certain type checks that typescript will get wrong, module initialization in the wrong order / racy, etc.

I wouldn't be surprised either - but some preliminary checks I did with TLA + type errors did report the correct error. But this is just a bandaid until TypeScript properly parses TLA.

@ry ry merged commit ae26a9c into denoland:master Sep 30, 2019
@ry ry deleted the top_level_await_ts branch September 30, 2019 16:38
@hayd
Copy link
Contributor

hayd commented Sep 30, 2019

Is top level for-await a distinct typescript/V8 issue?

@ry
Copy link
Member Author

ry commented Sep 30, 2019

@hayd yes - it’s not yet supported in v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support top-level await
4 participants