Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge build.yml and lint.yml (#3063) #3066

Merged
merged 2 commits into from
Oct 5, 2019
Merged

merge build.yml and lint.yml (#3063) #3066

merged 2 commits into from
Oct 5, 2019

Conversation

riginding
Copy link
Contributor

@riginding riginding commented Oct 4, 2019

Fixes #3063

I hope I understood the issue correctly.

The lint workflow should work properly. The benchmark build was failing because I didn't set up the necessary secret. it should run in the denoland/deno repository.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one issue...

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 2a02107 into denoland:master Oct 5, 2019
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: merge .github/workflows/lint.yml with .github/workflows/build.yml
2 participants