Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[std/ws] provide default close code for ws.close() #4172

Merged
merged 1 commit into from
Feb 28, 2020
Merged

[std/ws] provide default close code for ws.close() #4172

merged 1 commit into from
Feb 28, 2020

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Feb 28, 2020

  • ws.close() now can be called without arguments.
  • 1000 (Normal Closure) is used for default close code.
  • reformatted ws test descriptions.

ry
ry approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 9075daa into denoland:master Feb 28, 2020
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
@keroxp @mhvsa
[std/ws] provide default close code for ws.close() (denoland#4172)
20bc83c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@keroxp
[std/ws] provide default close code for ws.close() (denoland/deno#4172)
9696eae
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp
[ws] provide default close code for ws.close() (denoland/deno#4172)
5f80413
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp @caspervonb
[ws] provide default close code for ws.close() (denoland/deno#4172)
b7542db
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp @caspervonb
[ws] provide default close code for ws.close() (denoland/deno#4172)
e41c0b1
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
[ws] provide default close code for ws.close() (denoland/deno#4172)
0fd2bbb
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
[ws] provide default close code for ws.close() (denoland/deno#4172)
9ace8c3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
[ws] provide default close code for ws.close() (denoland/deno#4172)
21138da
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @denobot
[ws] provide default close code for ws.close() (denoland/deno#4172)
db16313
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@keroxp @denobot
[ws] provide default close code for ws.close() (denoland/deno#4172)
0c54233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroxp @ry