Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internel error frames dimmer #4201

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Make internel error frames dimmer #4201

merged 3 commits into from
Mar 1, 2020

Conversation

kevinkassimo
Copy link
Contributor

@kevinkassimo kevinkassimo commented Mar 1, 2020 •
edited
Loading

Make frames with filename prefixed with $deno$ dimmer.

For a given script:

function f() {
  Deno.openSync("./nonexistent");
}

function g() {
  f();
}

g();

On dark terminal:
Screen Shot 2020-02-29 at 5 41 45 PM
On light terminal:
Screen Shot 2020-02-29 at 5 42 02 PM

NO_COLOR=1 still works just as before.

@kevinkassimo kevinkassimo changed the title Make internel error frames dimmed Make internel error frames dimmer Mar 1, 2020
ry
ry reviewed Mar 1, 2020
View reviewed changes
cli/fmt_errors.rs Outdated
script_name: String,
line: i64,
column: i64,
is_raw: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/is_raw/is_internal

ry
ry reviewed Mar 1, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool feature!

ry
ry approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit c3661e9 into denoland:master Mar 1, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Mar 3, 2020
@kevinkassimo @bartlomieju
Make internel error frames dimmer (denoland#4201)
5843090
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
@kevinkassimo @mhvsa
Make internel error frames dimmer (denoland#4201)
b8c98d8
@nayeemrmn nayeemrmn mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinkassimo @ry