fix(op_crates/web): Use "deno:" URLs for internal script specifiers

[nayeemrmn]

Fixes deno.exe eval "new Event()" panic. Described in #7369 (comment).

Internal script specifiers use URLs in the form of deno:<repo-relative path to file>. That lets Deno developers conveniently Ctrl+click the paths (checked in VSCode).

Additionally, having a clear prefix lets us restore dimming for internal stack frames: #4201.

The panic is fixed by ignoring deno: URLs when source mapping.

[nayeemrmn]

cc @bartlomieju

[ry]

Thanks for the patch - looks good.

I wonder if you could experiment with moving the test into the deno_web crate? Since this is a bug in deno_web, ideally the test would be there too.

This is experimental because we haven't yet developed good patterns for how to do tests in op crates. However this is a pretty simple situation - so it will be an instructive experiment. Consider not using itest.

[bartlomieju]

@nayeemrmn thanks for this catch! The code looks good, I only wonder if we should show op_crates/web/<filename> instead of web/<filename>. @ry WDYT?

[nayeemrmn]

I wonder if you could experiment with moving the test into the deno_web crate? Since this is a bug in deno_web, ideally the test would be there too.

I'll look into adding a local test for relative script names. The panic is occurring in CLI, I think the itest should stay to test a component of op_crates integration.

I only wonder if we should show op_crates/web/<filename> instead of web/<filename>

I agree, also we should show cli/rt/... instead of rt/... so the root is consistent.

[ry]

I only wonder if we should show op_crates/web/ instead of web/. @ry WDYT?

I guess that would be better...

It would be cool to eventually use some sort of absolute URL (maybe crate://deno@1.3.3/op_crates/web/01_event.js)

[nayeemrmn]

It would be cool to eventually use some sort of absolute URL (maybe crate://deno@1.3.3/op_crates/web/01_event.js)

I was actually just experimenting with deno:op_crates/web/.... This is likely the most appropriate URL format since it's just protocol + pathname. It also works with Ctrl+click in integrated terminals when developing Deno:

Some kind of prefix is necessary to restore #4201, and we could do cool things like showing the source line for the first non-deno stack frame.

[nayeemrmn]

@ry Please review.

[bartlomieju]

Nitpick: why deno:op_crates/web instead of deno://op_crates/web?

[nayeemrmn]

Nitpick: why deno:op_crates/web instead of deno://op_crates/web?

@bartlomieju deno://op_crates/web makes op_crates the host, quite arbitrarily.

A bit better would be deno:///op_crates/web but that makes it an absolute path which would never be correctly meaningful. It's not Ctrl+clickable, for example.

[ry]

I think this seems pretty reasonable and clean.

@bartlomieju please land if you're okay with it this too.

[bartlomieju]

Yeah I agree, @nayeemrmn's right about the host part.

[bartlomieju]

LGTM, thank you @nayeemrmn