-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(std/encoding/csv): enable skipped tests #4520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool - thanks! Just one comment...
std/encoding/csv.ts
Outdated
@@ -9,6 +11,11 @@ import { assert } from "../testing/asserts.ts"; | |||
|
|||
const INVALID_RUNE = ["\r", "\n", '"']; | |||
|
|||
export const ErrBareQuote = 'bare " in non-quoted-field'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is conventional to do these as ERR_BARE_QUOTE
in both JavaScript and Deno.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @uki00a !
std/encoding/csv.ts
(except for theHugeLines
test. See TextProtoReader.readLine (probably) returns a wrong result if the line is too long #4521)