refactor(cli/js/permissions): Split read/write permission descriptors #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
Apr 16, 2020
| @@ -1668,11 +1668,12 @@ declare namespace Deno { | |||
| Busy: ErrorConstructor; | |||
| }; | |||
|
|
|||
| /** **UNSTABLE**: potentially want names to overlap more with browser. | |||
There was a problem hiding this comment.
We don't. Even if appropriately named permissions existed on the web, it's nonsense to try and align ours so we can get away with putting Deno's permissions in navigator, since they will inevitably mean different things.
The strategy would be to leave Deno.permissions as is and also have navigator.permissions to contain web-compatible permissions like "notifications" (#4257 (comment)) and "persistent-storage" (#1657).
If you really want to have one permissions namespace, an alternative strategy would be to allow this:
navigator.permissions.query({ name: Deno.symbols.read })
nayeemrmn
force-pushed
the
read-write-permissions
branch
from
3fa22fe
to
b1368da
Compare
|
@ry Please review. |
bartlomieju
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% confident that these might not have different options later... one for each permission is simpler anyway.