New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL: Make zero a valid port #4963

Merged

ry merged 1 commit into denoland:master from marcosc90:zero-valid-port

Apr 28, 2020

Contributor

marcosc90 commented Apr 28, 2020

Improvement of #4954 to make 0 a valid port.

Also port should be an integer, removed a duplicated test, added more tests cases.


          url: Make zero a valid port

6dfc786

ry approved these changes

View reviewed changes

Member

ry left a comment

LGTM

ry merged commit 927a771 into denoland:master

marcosc90 deleted the zero-valid-port branch

April 28, 2020 14:51

SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request


          url: Make zero a valid port (denoland#4963)

bea916a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet