BREAKING: disallow static import of local modules from remote modules #5050
Conversation
This commit changes module loading logic to disallow statically import local module (file:// scheme) from remote modules (http://, https:// schemes).
bartlomieju
changed the title
|
Ref #3401 |
|
This would break some nice use cases. One that comes to mind is filesystem based web server routes. |
How so? Dynamic imports are still working. |
|
Oh whoops, I misread the title - I missed the static part. Then this seems like a really nice change :-D |
| @@ -0,0 +1,2 @@ | |||
| [WILDCARD] | |||
| Remote module are not allowed to statically import local modules. Use dynamic import instead. | |||
There was a problem hiding this comment.
In case of .js-only imports the error is very sparse and has no stack trace...
bartlomieju
changed the title
| // TODO(bartlomieju): duplicated from `state.rs::ModuleLoader::load` - deduplicate | ||
| // Verify that remote file doesn't try to statically import local file. | ||
| if let Some(referrer) = ref_specifier_.as_ref() { | ||
| let referrer_url = referrer.as_url(); | ||
| match referrer_url.scheme() { | ||
| "http" | "https" => { |
There was a problem hiding this comment.
This cruft will be removed during TS compiler refactor
…denoland#5050) This commit changes module loading logic to disallow statically import local module (file:// scheme) from remote modules (http://, https:// schemes).
|
@bartlomieju I've run into a nice (IMO) use-case that this logic prevents: I'm using an import map to remap one of my transitive dependencies to a local file, but when trying to bundle my app it fails with the error: Can I work it around somehow? PS I submitted the issue: #7723, it's probably better to keep the discussion there |
|
@vovaguguiev currently there is no way. Would you mind opening an issue with your use case? |
This commit changes module loading logic to disallow statically import
local module (file:// scheme) from remote modules (http://, https://
schemes).