Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: make Worker.deno unstable; remove stale worker tests #5128

Merged
merged 3 commits into from May 7, 2020
Merged

BREAKING: make Worker.deno unstable; remove stale worker tests #5128

merged 3 commits into from May 7, 2020

Conversation

bartlomieju
Copy link
Member

This PR adds unstable check if Worker.deno option is used.

Additionally stale tests for workers were removed (they were disabled anyway,
and we have cli/tests/worker_test.ts where new tests can be added).

@bartlomieju bartlomieju requested a review from ry May 7, 2020 12:08
@bartlomieju bartlomieju mentioned this pull request May 7, 2020
Merged
ry
ry reviewed May 7, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - I'm sad to make this feature unstable - but I think it's the right move.

Maybe you can add something to the manual about accessing Deno in a worker? I guess there won't be any way for people to discover this otherwise.

@bartlomieju
Copy link
Member Author

Looks fine - I'm sad to make this feature unstable - but I think it's the right move.

Maybe you can add something to the manual about accessing Deno in a worker? I guess there won't be any way for people to discover this otherwise.

#4325 <-- I'll tend to it before the release

@bartlomieju bartlomieju requested a review from ry May 7, 2020 15:39
ry
ry reviewed May 7, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update docs/toc.json

docs/runtime/workers.md Show resolved Hide resolved
@bartlomieju bartlomieju requested a review from ry May 7, 2020 18:58
ry
ry approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit aca21da into denoland:master May 7, 2020
@bartlomieju bartlomieju deleted the make_worker_deno_unstable branch May 7, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry