Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: make Worker.deno unstable; remove stale worker tests #5128

Merged
merged 3 commits into from May 7, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions cli/ops/worker_host.rs
Expand Up @@ -184,6 +184,9 @@ fn op_create_worker(
};
let args_name = args.name;
let use_deno_namespace = args.use_deno_namespace;
if use_deno_namespace {
state.check_unstable("Worker.deno");
}
let parent_state = state.clone();
let mut state = state.borrow_mut();
let global_state = state.global_state.clone();
Expand Down
23 changes: 0 additions & 23 deletions cli/tests/039_worker_deno_ns.ts

This file was deleted.

4 changes: 0 additions & 4 deletions cli/tests/039_worker_deno_ns.ts.out

This file was deleted.

10 changes: 0 additions & 10 deletions cli/tests/039_worker_deno_ns/has_ns.ts

This file was deleted.

1 change: 0 additions & 1 deletion cli/tests/039_worker_deno_ns/maybe_ns.ts

This file was deleted.

10 changes: 0 additions & 10 deletions cli/tests/039_worker_deno_ns/no_ns.ts

This file was deleted.

6 changes: 0 additions & 6 deletions cli/tests/040_worker_blob.ts

This file was deleted.

1 change: 0 additions & 1 deletion cli/tests/040_worker_blob.ts.out

This file was deleted.

3 changes: 0 additions & 3 deletions cli/tests/error_worker_dynamic.ts

This file was deleted.

3 changes: 0 additions & 3 deletions cli/tests/error_worker_dynamic.ts.out

This file was deleted.

20 changes: 1 addition & 19 deletions cli/tests/integration_tests.rs
Expand Up @@ -985,6 +985,7 @@ fn workers() {
.arg("test")
.arg("--reload")
.arg("--allow-net")
.arg("--unstable")
.arg("workers_test.ts")
.spawn()
.unwrap()
Expand Down Expand Up @@ -1080,17 +1081,6 @@ itest!(_038_checkjs {
output: "038_checkjs.js.out",
});

// TODO(bartlomieju): re-enable
itest_ignore!(_039_worker_deno_ns {
args: "run --reload 039_worker_deno_ns.ts",
output: "039_worker_deno_ns.ts.out",
});

itest_ignore!(_040_worker_blob {
args: "run --reload 040_worker_blob.ts",
output: "040_worker_blob.ts.out",
});

itest!(_041_dyn_import_eval {
args: "eval import('./subdir/mod4.js').then(console.log)",
output: "041_dyn_import_eval.out",
Expand Down Expand Up @@ -1483,14 +1473,6 @@ itest!(error_local_static_import_from_remote_js {
output: "error_local_static_import_from_remote.js.out",
});

// TODO(bartlomieju) Re-enable
itest_ignore!(error_worker_dynamic {
args: "run --reload error_worker_dynamic.ts",
check_stderr: true,
exit_code: 1,
output: "error_worker_dynamic.ts.out",
});

itest!(exit_error42 {
exit_code: 42,
args: "run --reload exit_error42.ts",
Expand Down