Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add section about multiple deps.ts #6196

Closed
wants to merge 1 commit into from

Conversation

nayeemrmn
Copy link
Collaborator

Closes #6194. The problem of large unused imports being included due to deps.ts is alleviated by suggesting that authors selectively place independent functionalities into independent dependency trees (by having multiple deps.ts/mod.ts).

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally agree with this. But I’m not sure this belongs in the manual. It’s quite abstract and without concrete recommendations... maybe it’s better left unsaid until best practices solidify in the community?

@@ -76,6 +76,23 @@ import { assertEquals, runTests, test } from "./deps.ts";
This design circumvents a plethora of complexity spawned by package management
software, centralized code repositories, and superfluous file formats.

#### Best practice: Selectively break up libraries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/libraries/modules

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to differentiate between an executable project and an importable library. Are these two really interchangeable?

@nayeemrmn
Copy link
Collaborator Author

The linked issue is more about varying incremental compile times, because I guess all transitive dependencies are type checked again. Also I agree with above. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential performance issue related to the current deps.ts/mod.ts convention
2 participants