fix directory type

[fuxingZhang]

I use tar.append to add a folder and I get incorrect entry.type.

[CLAassistant]

All committers have signed the CLA.

[ry]

Isn’t there an enum that can be used here? The value “5” and “0” are not very descriptive. (I see that it was using “0” before but that seems like bad code. Now would be a good opportunity to clean this up.)

[fuxingZhang]

I have updated the code, but I am not sure if it is appropriate.

I referenced some websites, and I add "fifo" and "contiguous-file" into Types

https://github.com/mafintosh/tar-stream
http://www.gnu.org/software/tar/manual/html_node/Standard.html

[ry]

If the value is only used as a string why not use a string here?

enum Types {
  "file" = "0",
  "link" = "1",
  // ...
}

I suggest "FileTypes" instead of "Types" - just a bit less ambiguous.

[fuxingZhang]

in method #getMetadata of Class Untar, convert a numeric string to string, such as "0" => "file"

// before
meta.type = types[meta.type as string] || meta.type;
// now
meta.type = FileTypes[parseInt(meta.type!)] ?? meta.type;

if the value is string, i get an error

enum FileTypes {
  "file" = "0",
  "link" = 1,
}
console.log(FileTypes.file);
// ok
console.log(FileTypes[1]);
// throw an error: Element implicitly has an 'any' type because index expression is not of type 'number'.ts(7015)
console.log(FileTypes["0"]);

[ry]

LGTM - thanks @fuxingZhang