Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: deno_lint, dprint, swc #6928

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Conversation

bartlomieju
Copy link
Member

This commit upgrades:
deno_lint 0.1.20
dprint-plugin-typescript 0.25.0
swc_ecmascript 0.1.0

SWC is no longer reexported from dprint nor deno_lint.

Effectively reducing binary size by about 2.5Mb

cargo bloat --release --crates
 File  .text     Size Crate
20.1%  46.0%   8.1MiB rusty_v8
 7.9%  18.2%   3.2MiB [Unknown]
 2.5%   5.8%   1.0MiB std
 1.7%   3.9% 711.9KiB dprint_plugin_typescript
 1.6%   3.6% 653.9KiB swc_ecma_transforms
 1.6%   3.6% 646.2KiB deno_lint
 1.1%   2.5% 451.5KiB deno
 0.9%   2.0% 354.5KiB deno_core
 0.7%   1.7% 305.8KiB reqwest
 0.6%   1.4% 248.3KiB rustls
 0.5%   1.1% 189.7KiB clap
 0.4%   0.9% 170.5KiB regex
 0.4%   0.9% 157.5KiB tokio
 0.3%   0.7% 128.2KiB h2
 0.3%   0.6% 111.1KiB futures_util
 0.3%   0.6% 106.3KiB swc_ecma_ast
 0.2%   0.5%  95.7KiB hyper
 0.2%   0.5%  88.9KiB regex_syntax
 0.2%   0.5%  85.1KiB ring
 0.2%   0.5%  82.5KiB swc_ecma_codegen
 2.0%   4.6% 824.5KiB And 106 more crates. Use -n N to show more.
43.5% 100.0%  17.6MiB .text section size, the file size is 40.4MiB

@bartlomieju bartlomieju requested a review from ry July 31, 2020 14:29
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit b718e6f into denoland:master Jul 31, 2020
@bartlomieju bartlomieju deleted the upgrade_dlint branch July 31, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants