add env_logger (fix #3869) #7142

tokiedokie · 2020-08-21T05:05:52Z

using env_logger for logging

ry

@tokiedokie Nice - thank you! I've been wanting this for a long time.

This branch, using -L=debug

~/src/deno> ./target/debug/deno run -L=debug cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG JS - cwd /Users/rld/src/deno
DEBUG JS - args []
main_module file:///Users/rld/src/deno/cli/tests/002_hello.ts
fetch_source_file specifier: file:///Users/rld/src/deno/cli/tests/002_hello.ts maybe_referrer: None
⚠️️  Granted read access to "/Users/rld/src/deno/cli/tests/002_hello.ts"
compiled filename: "/Users/rld/Library/Caches/deno/gen/file/Users/rld/src/deno/cli/tests/002_hello.ts.js"
register_complete file:///Users/rld/src/deno/cli/tests/002_hello.ts
Hello World

This branch using RUST_LOG in various ways

~/src/deno> RUST_LOG=debug ./target/debug/deno run cli/tests/002_hello.ts
Hello World
~/src/deno> RUST_LOG=1 ./target/debug/deno run cli/tests/002_hello.ts
Hello World
~/src/deno> RUST_LOG=deno ./target/debug/deno run cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
main_module file:///Users/rld/src/deno/cli/tests/002_hello.ts
fetch_source_file specifier: file:///Users/rld/src/deno/cli/tests/002_hello.ts maybe_referrer: None
⚠️️  Granted read access to "/Users/rld/src/deno/cli/tests/002_hello.ts"
compiled filename: "/Users/rld/Library/Caches/deno/gen/file/Users/rld/src/deno/cli/tests/002_hello.ts.js"
register_complete file:///Users/rld/src/deno/cli/tests/002_hello.ts
Hello World

master branch using -L=debug

~/src/deno> deno run -L=debug cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG JS - cwd /Users/rld/src/deno
DEBUG JS - args []
main_module file:///Users/rld/src/deno/cli/tests/002_hello.ts
fetch_source_file specifier: file:///Users/rld/src/deno/cli/tests/002_hello.ts maybe_referrer: None
⚠️️  Granted read access to "/Users/rld/src/deno/cli/tests/002_hello.ts"
Check file:///Users/rld/src/deno/cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG TS - "sendSync" "op_now"
⚠️️  Granted access to high precision time
DEBUG TS - ">>> compile start" {"rootNames":["file:///Users/rld/src/deno/cli/tests/002_hello.ts"]}
DEBUG TS - "compiler::host.getCompilationSettings()"
DEBUG TS - "compiler::host.getDefaultLibFileName()"
DEBUG TS - "compiler::host.getSourceFile" "file:///Users/rld/src/deno/cli/tests/002_hello.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.window.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.ns.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2016.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es5.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.core.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.collection.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.iterable.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.symbol.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.generator.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.proxy.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.reflect.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.symbol.wellknown.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2016.array.include.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.object.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.sharedmemory.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.typedarrays.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.asynciterable.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.asyncgenerator.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.regexp.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.array.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.object.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.symbol.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.bigint.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.symbol.wellknown.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.shared_globals.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.web.d.ts"
DEBUG TS - "compiler::host.writeFile" "deno://002_hello.js"
DEBUG TS - "compiler::host.writeFile" "cache:///tsbuildinfo.json"
DEBUG TS - "<<< compile end" {"rootNames":["file:///Users/rld/src/deno/cli/tests/002_hello.ts"]}
DEBUG TS - "sendSync" "op_now"
⚠️️  Granted access to high precision time
DEBUG TS - "sendSync" "op_compiler_respond"
DEBUG - Compilation Statistics:
Files: 44
Nodes: 29376
Identifiers: 11501
Symbols: 6543
Types: 84
Instantiations: 2
Parse time: 8
Bind time: 133
Check time: 11
Emit time: 14
Total TS time: 166
Compile time: 184.027165
compiled filename: "/Users/rld/Library/Caches/deno/gen/file/Users/rld/src/deno/cli/tests/002_hello.ts.js"
register_complete file:///Users/rld/src/deno/cli/tests/002_hello.ts
Hello World

Why is the output different?

tokiedokie · 2020-08-22T06:16:44Z

@ry the difference between master's deno run -L=debug cli/tests/002_hello.ts and this branch's ./target/debug/deno run -L=debug cli/tests/002_hello.ts is caused by the cache
run without cache, I get same output

master branch

❯ ./target/debug/deno run -L=debug --reload cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG JS - cwd /home/ubuntu/deno
DEBUG JS - args []
main_module file:///home/ubuntu/deno/cli/tests/002_hello.ts
fetch_source_file specifier: file:///home/ubuntu/deno/cli/tests/002_hello.ts maybe_referrer: None
⚠️️  Granted read access to "/home/ubuntu/deno/cli/tests/002_hello.ts"
Check file:///home/ubuntu/deno/cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG TS - "sendSync" "op_now"
⚠️️  Granted access to high precision time
DEBUG TS - ">>> compile start" {"rootNames":["file:///home/ubuntu/deno/cli/tests/002_hello.ts"]}
DEBUG TS - "compiler::host.getCompilationSettings()"
DEBUG TS - "compiler::host.getDefaultLibFileName()"
DEBUG TS - "compiler::host.getSourceFile" "file:///home/ubuntu/deno/cli/tests/002_hello.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.window.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.ns.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2016.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es5.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.core.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.collection.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.iterable.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.symbol.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.generator.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.proxy.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.reflect.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.symbol.wellknown.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2016.array.include.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.object.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.sharedmemory.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.typedarrays.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.asynciterable.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.asyncgenerator.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.regexp.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.array.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.object.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.symbol.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.bigint.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.symbol.wellknown.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.shared_globals.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.web.d.ts"
DEBUG TS - "compiler::host.writeFile" "deno://002_hello.js"
DEBUG TS - "compiler::host.writeFile" "cache:///tsbuildinfo.json"
DEBUG TS - "<<< compile end" {"rootNames":["file:///home/ubuntu/deno/cli/tests/002_hello.ts"]}
DEBUG TS - "sendSync" "op_now"
⚠️️  Granted access to high precision time
DEBUG TS - "sendSync" "op_compiler_respond"
DEBUG - Compilation Statistics:
Files: 44
Nodes: 29376
Identifiers: 11501
Symbols: 8266
Types: 3668
Instantiations: 1168
Parse time: 151
Bind time: 1577
Check time: 3801
Emit time: 68
Total TS time: 5597
Compile time: 5782.2096
compiled filename: "/home/ubuntu/.cache/deno/gen/file/home/ubuntu/deno/cli/tests/002_hello.ts.js"
register_complete file:///home/ubuntu/deno/cli/tests/002_hello.ts
Hello World

this PR branch

❯ ./target/debug/deno run -L=debug --reload cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG JS - cwd /home/ubuntu/deno
DEBUG JS - args []
main_module file:///home/ubuntu/deno/cli/tests/002_hello.ts
fetch_source_file specifier: file:///home/ubuntu/deno/cli/tests/002_hello.ts maybe_referrer: None
⚠️️  Granted read access to "/home/ubuntu/deno/cli/tests/002_hello.ts"
Check file:///home/ubuntu/deno/cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
DEBUG TS - "sendSync" "op_now"
⚠️️  Granted access to high precision time
DEBUG TS - ">>> compile start" {"rootNames":["file:///home/ubuntu/deno/cli/tests/002_hello.ts"]}
DEBUG TS - "compiler::host.getCompilationSettings()"
DEBUG TS - "compiler::host.getDefaultLibFileName()"
DEBUG TS - "compiler::host.getSourceFile" "file:///home/ubuntu/deno/cli/tests/002_hello.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.window.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.ns.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2016.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es5.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.core.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.collection.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.iterable.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.symbol.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.generator.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.proxy.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.reflect.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2015.symbol.wellknown.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2016.array.include.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.object.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.sharedmemory.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2017.typedarrays.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.asynciterable.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.asyncgenerator.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.regexp.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2018.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.array.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.object.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2019.symbol.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.bigint.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.es2020.symbol.wellknown.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.intl.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.string.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.esnext.promise.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.shared_globals.d.ts"
DEBUG TS - "compiler::host.getSourceFile" "asset:///lib.deno.web.d.ts"
DEBUG TS - "compiler::host.writeFile" "deno://002_hello.js"
DEBUG TS - "compiler::host.writeFile" "cache:///tsbuildinfo.json"
DEBUG TS - "<<< compile end" {"rootNames":["file:///home/ubuntu/deno/cli/tests/002_hello.ts"]}
DEBUG TS - "sendSync" "op_now"
⚠️️  Granted access to high precision time
DEBUG TS - "sendSync" "op_compiler_respond"
DEBUG - Compilation Statistics:
Files: 44
Nodes: 29376
Identifiers: 11501
Symbols: 8266
Types: 3668
Instantiations: 1168
Parse time: 168
Bind time: 1327
Check time: 2885
Emit time: 76
Total TS time: 4456
Compile time: 4556.9652
compiled filename: "/home/ubuntu/.cache/deno/gen/file/home/ubuntu/deno/cli/tests/002_hello.ts.js"
register_complete file:///home/ubuntu/deno/cli/tests/002_hello.ts
Hello World

I updated RUST_LOG

the args of RUST_LOG is here

using RUST_LOG=debug outputs debug massage from Rust not include TS/JS

RUST_LOG=debug ./target/debug/deno run cli/tests/002_hello.ts
Deno isolate init with snapshots.
rust:shared_queue:reset
main_module file:///home/ubuntu/deno/cli/tests/002_hello.ts
fetch_source_file specifier: file:///home/ubuntu/deno/cli/tests/002_hello.ts maybe_referrer: None
⚠️️  Granted read access to "/home/ubuntu/deno/cli/tests/002_hello.ts"
compiled filename: "/home/ubuntu/.cache/deno/gen/file/home/ubuntu/deno/cli/tests/002_hello.ts.js"
register_complete file:///home/ubuntu/deno/cli/tests/002_hello.ts
Hello World

using RUST_LOG=deno::permissions outputs debug message from cli/permissions.rs

❯ RUST_LOG=deno::permissions ./target/debug/deno run --reload cli/tests/002_hello.ts
⚠️️  Granted read access to "/home/ubuntu/deno/cli/tests/002_hello.ts"
Hello World

ry · 2020-08-23T13:44:19Z

Nice!

It would be good to get a test demonstrating the RUST_LOG facility and also to add some documentation (probably to the command-line help) about this feature.

tokiedokie · 2020-08-25T04:03:57Z

some tests won't be passed because of #7185

bartlomieju · 2020-08-27T09:06:34Z

@tokiedokie we still want messages like Check <file> or Download <file> to go to stderr - can env_logger be configured in such a way to debug messages go to stdout, while warnings and errors got to stderr? Alternatively you can keep it the way it's right now - ie. push all log messages from Rust to stderr.

bartlomieju · 2020-08-27T10:01:42Z

@tokiedokie one more thing; while you're working on the logger, could you try to address #6641 as well?

tokiedokie · 2020-08-27T11:31:17Z

@bartlomieju thank you for your feedback
I couldn't find the way to configure env_logger in such a way to debug messages go to stdout, while warnings and errors got to stderr
I keep making all logs go to stderr

I will try to find #6641

tokiedokie · 2020-08-28T02:50:36Z

@bartlomieju I confirmed warn logs (#6641)
Should I change default leg level from Info to Error so deno doesn't output warn logs by default?

bartlomieju · 2020-09-02T10:57:17Z

@bartlomieju I confirmed warn logs (#6641)
Should I change default leg level from Info to Error so deno doesn't output warn logs by default?

@tokiedokie I think that might brake other output after all... Let's skip this issue in this PR. Could you rebase your branch so we can land it?

tokiedokie · 2020-09-02T13:34:43Z

@bartlomieju @ry Done. Please review

cli/tests/debug_with_log_level_and_RUST_LOG.out

ry

LGTM - thank you @tokiedokie

tokiedokie marked this pull request as ready for review August 21, 2020 06:01

ry reviewed Aug 21, 2020

View reviewed changes

tokiedokie closed this Aug 22, 2020

tokiedokie reopened this Aug 22, 2020

tokiedokie force-pushed the use_env_logger branch from ea2214f to 61c65f6 Compare August 27, 2020 14:04

tokiedokie added 17 commits September 2, 2020 21:55

add env_logger

1ef603d

update env_logger::bulder().format()

af21424

remove comments

4ac3e45

available RUST_LOG

df874ec

fix typo

fd5aaa3

fmt

1821dd1

add tests for RUST_LOG

80a36ff

fmt

73119be

lint

1c09161

update debug_with_log_level_and_rust_log

b5d40f9

remove RUST_LOG env after process ended

ee4e2dc

target stdout

30e9599

use util::run_and_collect_output

986ae6b

add .out

0332fd5

rust debug logs go to stderr

b5a17b9

update test log massage

0d89bae

submodule update

f69b198

tokiedokie and others added 4 commits September 2, 2020 21:55

actual actual get stderr

1fc3142

update logs for windows

41aa579

add help message

4633dd4

debug logs -> logs

f1ae2c6

tokiedokie force-pushed the use_env_logger branch from 3b0f392 to f1ae2c6 Compare September 2, 2020 12:55

ry reviewed Sep 2, 2020

View reviewed changes

cli/tests/debug_with_log_level_and_RUST_LOG.out Outdated Show resolved Hide resolved

ry added 6 commits September 2, 2020 09:50

remove tests

a9863aa

add RUST_LOG test

a3954af

undo RUST_LOG docs

1eb51e2

x

4fa9876

x

e533da7

fix

baa6b19

ry approved these changes Sep 3, 2020

View reviewed changes

ry merged commit fcee426 into denoland:master Sep 3, 2020

tokiedokie deleted the use_env_logger branch September 4, 2020 07:23

magurotuna mentioned this pull request Sep 14, 2020

Deno 1.4.0 fmt --quiet option regression #7463

Closed

bartlomieju mentioned this pull request Sep 15, 2020

adopt env_logger #3869

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add env_logger (fix #3869) #7142

add env_logger (fix #3869) #7142

tokiedokie commented Aug 21, 2020 •

edited

Loading

ry left a comment

tokiedokie commented Aug 22, 2020 •

edited

Loading

ry commented Aug 23, 2020

tokiedokie commented Aug 25, 2020

bartlomieju commented Aug 27, 2020 •

edited

Loading

bartlomieju commented Aug 27, 2020 •

edited

Loading

tokiedokie commented Aug 27, 2020

tokiedokie commented Aug 28, 2020 •

edited

Loading

bartlomieju commented Sep 2, 2020

tokiedokie commented Sep 2, 2020

ry left a comment

add env_logger (fix #3869) #7142

add env_logger (fix #3869) #7142

Conversation

tokiedokie commented Aug 21, 2020 • edited Loading

ry left a comment

Choose a reason for hiding this comment

tokiedokie commented Aug 22, 2020 • edited Loading

ry commented Aug 23, 2020

tokiedokie commented Aug 25, 2020

bartlomieju commented Aug 27, 2020 • edited Loading

bartlomieju commented Aug 27, 2020 • edited Loading

tokiedokie commented Aug 27, 2020

tokiedokie commented Aug 28, 2020 • edited Loading

bartlomieju commented Sep 2, 2020

tokiedokie commented Sep 2, 2020

ry left a comment

Choose a reason for hiding this comment

tokiedokie commented Aug 21, 2020 •

edited

Loading

tokiedokie commented Aug 22, 2020 •

edited

Loading

bartlomieju commented Aug 27, 2020 •

edited

Loading

bartlomieju commented Aug 27, 2020 •

edited

Loading

tokiedokie commented Aug 28, 2020 •

edited

Loading