feat(std/fmt): add bright color variations #7241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
force-pushed
the
feat-std-fmt-bright-colors
branch
from
483805a
to
acf6e06
Compare
bartlomieju
reviewed
Aug 29, 2020
Comment on lines
+123
to
+126
| return brightBlack(str); | ||
| } | ||
|
|
||
| export function brightBlack(str: string): string { |
There was a problem hiding this comment.
Is change to gray intentional?
There was a problem hiding this comment.
Yes, did not want to remove any identifiers here but gray was returning 90 which is "bright black" so grey becomes an alias of it.
There was a problem hiding this comment.
For reference, Wikipedia has a pretty color table https://en.wikipedia.org/wiki/ANSI_escape_code#Terminal_output_sequences
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bright colors variations of the colors defined in std/fmt/colors.ts.
Closes #7240