Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deno.makeTempDir #737

Closed
wants to merge 2 commits into from
Closed

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 13, 2018

  • Added //js/make_temp_dir.ts and //js/make_temp_dir_test.ts
  • Added deno.makeTempDir and test of it

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you run format.py once more to remove some trailing whitespace?

@kt3k
Copy link
Member Author

kt3k commented Sep 13, 2018

@piscisaureus

Can you run format.py once more to remove some trailing whitespace?

Thanks for pointing! Done.

And I realized I forgot to remove the old implementation of makeTempDirSync in os.ts, so I removed it in a new commit ( 02c96d0 ).

@piscisaureus
Copy link
Member

Thanks! Landed in 0ca7301

@kt3k kt3k deleted the feature/make-temp-dir branch September 13, 2018 06:51
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
This is a first pass at `ARCHITECTURE.md`, a high-level overview of how
`deno_core` works.

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants