New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deno.makeTempDir #737

Closed
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Sep 13, 2018

  • Added //js/make_temp_dir.ts and //js/make_temp_dir_test.ts
  • Added deno.makeTempDir and test of it

@kt3k kt3k force-pushed the kt3k:feature/make-temp-dir branch from cb519a5 to 5906e7c Sep 13, 2018

@ry ry requested a review from piscisaureus Sep 13, 2018

@piscisaureus
Copy link
Collaborator

piscisaureus left a comment

LGTM. Can you run format.py once more to remove some trailing whitespace?

@kt3k kt3k force-pushed the kt3k:feature/make-temp-dir branch from 70b2bc8 to 02c96d0 Sep 13, 2018

@kt3k

This comment has been minimized.

Copy link
Contributor Author

kt3k commented Sep 13, 2018

@piscisaureus

Can you run format.py once more to remove some trailing whitespace?

Thanks for pointing! Done.

And I realized I forgot to remove the old implementation of makeTempDirSync in os.ts, so I removed it in a new commit ( 02c96d0 ).

@piscisaureus

This comment has been minimized.

Copy link
Collaborator

piscisaureus commented Sep 13, 2018

Thanks! Landed in 0ca7301

@kt3k kt3k deleted the kt3k:feature/make-temp-dir branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment