Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): rename CoreIsolate to JsRuntime #7373

Merged
merged 4 commits into from
Sep 6, 2020
Merged

refactor(core): rename CoreIsolate to JsRuntime #7373

merged 4 commits into from
Sep 6, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 6, 2020 •
edited
Loading

deno_core

  • rename core/core_isolate.rs to core/runtime.rs
  • rename CoreIsolate to JsRuntime
  • rename JSError to JsError
  • rename JSStackFrame to JsStackFrame

cli

  • update references from deno_core::CoreIsolate to deno_core::JsRuntime
  • rename deno_core::JSError to deno_core::JsError
  • rename fmt_errors::JSError to fmt_errors::JsError

Next up, update docstrings in core/

ry
ry reviewed Sep 6, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do JSError -> JsError for consistency's sake

ry
ry approved these changes Sep 6, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit f57a2c1 into denoland:master Sep 6, 2020
@bartlomieju bartlomieju deleted the rename_core_isolate branch September 6, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry