refactor: use ParsedModule and improve MediaTypes enum #7456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
bartlomieju
reviewed
Sep 14, 2020
There was a problem hiding this comment.
LGTM, thank you @kitsonk. I have only one nitpick - take it or leave it.
bartlomieju
reviewed
Sep 14, 2020
|
CC @kdy1 please take a look at |
|
Seems to close #7168 |
|
@bartlomieju yes, closes #7168 and cleans up any "magical" logic we had to use. |
kdy1
reviewed
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced the
ParsedModuleabstraction which holds the entire state for a parsed module and moves all related code toast.rsinstead of the semi-cryptically namedswc_utils.rs. This also improves and makesMediaTypemore idiomatic in Rust.