Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #7660 #7789

Closed
wants to merge 1 commit into from
Closed

fix #7660 #7789

wants to merge 1 commit into from

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Oct 2, 2020 •
edited
Loading

switch from rusttls-tls to native-tls

image

Closes #7660

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kitsonk
Copy link
Contributor

kitsonk commented Oct 2, 2020

Switching from rustls to something else is a big change and needs a lot more consideration.

cc/ @piscisaureus @bartlomieju

@CGQAQ

This comment has been minimized.

Sign in to view
@kitsonk
Copy link
Contributor

kitsonk commented Oct 2, 2020

I am not just talking about performance here. We just don't google core foundational crates and bang them into Deno.

This is something you discuss with the core team before you start raising PRs. Something like "hey, I think this might fix this issue..."

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Oct 2, 2020

MB, I was just tested on Windows 10, and it worked

@junlarsen junlarsen mentioned this pull request Oct 2, 2020
Closed
@kitsonk
Copy link
Contributor

kitsonk commented Oct 3, 2020

As discussed online, I am going to close this. For fixing #7660 we need to first figure out why rustls is failing, and if there is any way to get it to work before we attempt to replace it.

@kitsonk kitsonk closed this Oct 3, 2020
@CGQAQ CGQAQ deleted the fix#7660 branch October 3, 2020 03:00
@jopemachine jopemachine mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetching https://1.1.1.1 or any other bare IP address fails with 'invalid dnsname'
4 participants
@CGQAQ @CLAassistant @kitsonk @crypt096