Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(unstable): enable importsNotUsedAsValues by default (#7413)" #7800

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Oct 2, 2020

This reverts commit fbb18d4.

Ref #7413.

As discussed, the --no-check incompatiblity we were seeing with import { MyType } from "./file.ts"; was a symptom of swc-project/swc#1065 which is now fixed. The rule is no longer was never really needed.

@ry ry requested a review from lucacasonato October 2, 2020 14:25
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - before merging I want to confirm that this case gets stripped correctly now:

import { MyType } from "./foo.ts";
export type { MyType };

@nayeemrmn
Copy link
Collaborator Author

nayeemrmn commented Oct 3, 2020

before merging I want to confirm that this case gets stripped correctly now:

import { MyType } from "./foo.ts";
export type { MyType };

Actually, just after opening this I realised the re-export thing was still broken and fixed it in swc: swc-project/swc#1126. Reiterating that I don't think these temporary swc bugs justify imposing rules for type checking so it breaks there, too. That's for fundamental incompatibilities, like how isolatedModules is needed for an efficient --no-check.

@nayeemrmn
Copy link
Collaborator Author

Also I think this change and that swc fix will both release at our next version.

@lucacasonato
Copy link
Member

Yeah lets merge this then. As it is fixed upstream we will get the fix in Deno before 1.4.5 is released.

@lucacasonato lucacasonato merged commit 315724b into denoland:master Oct 3, 2020
@nayeemrmn nayeemrmn deleted the revert-7413 branch October 3, 2020 14:58
JavascriptMick pushed a commit to JavascriptMick/deno that referenced this pull request Oct 5, 2020
Soremwar pushed a commit to Soremwar/deno that referenced this pull request Oct 6, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants