Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/runtime): Indicate exceptions in promises #8124

Merged
merged 2 commits into from
Oct 26, 2020
Merged

fix(core/runtime): Indicate exceptions in promises #8124

merged 2 commits into from
Oct 26, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Closes #4879.

Promise.reject(new Error("foo"));

// Before:
// Uncaught Error: foo
// ...

// After:
// Uncaught (in promise) Error: foo
// ...

image

kitsonk
kitsonk approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much nicer!!!

@kitsonk kitsonk merged commit 822e5b6 into denoland:master Oct 26, 2020
@nayeemrmn nayeemrmn deleted the exception-in-promise branch October 26, 2020 04:28
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@nayeemrmn
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
526ee63 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
b8c9339 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
7283712 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
2b09fa2 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
bd27409 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
ecab9ce 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
b6d6526 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @denobot
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
ca6f2c0 
Fixes denoland/deno#4879
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@nayeemrmn @denobot
fix(core/runtime): Indicate exceptions in promises (denoland/deno#8124)
2eaf763 
Fixes denoland/deno#4879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled promise rejections are confusing
2 participants
@nayeemrmn @kitsonk